ci: add retries to test setup in case the Atlas Dev environment is unstable #494
+104
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry mechanisms to test setup and teardown operations for Atlas integration tests to improve stability when the Atlas Dev environment is unstable.
- Introduces
beforeAllWithRetryandafterAllWithRetryhelper functions with exponential backoff - Replaces standard
beforeAllandafterAllcalls with retry-enabled versions across test files - Removes explicit error handling in favor of centralized retry logic
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/integration/tools/atlas/atlasHelpers.ts | Adds retry helper functions and updates withProject to use them |
| tests/integration/tools/atlas/projects.test.ts | Replaces afterAll with afterAllWithRetry |
| tests/integration/tools/atlas/clusters.test.ts | Replaces both beforeAll and afterAll with retry versions |
| tests/integration/tools/atlas/accessLists.test.ts | Replaces both beforeAll and afterAll with retry versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
We did a few fixes and this might not be necessary. I'll close the PR and we can implement retries afterwards if we need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist